Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verbose behavior in Rails within Python script (GH-178) #239

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

spehl-max
Copy link
Contributor

  • Address verbose output issue when running Rails command from a Python script.
  • When user runs rails with verbose=true the set_verbose() function is now called.
  • Response to GitHub discussion Logging #178.

@spehl-max spehl-max force-pushed the feature/logging_inconsistency_fix branch from 5945495 to 5c5bc55 Compare December 22, 2023 03:08
- Response to GitHub discussion NVIDIA#178.

- Address verbose output issue when running Rails commands from a Python script.

Signed-off-by: Max Spehlmann <mspehlm@ncsu.edu>
@spehl-max spehl-max force-pushed the feature/logging_inconsistency_fix branch from 5c5bc55 to 53f4f48 Compare December 22, 2023 03:27
@drazvan drazvan self-requested a review January 11, 2024 14:02
@drazvan
Copy link
Collaborator

drazvan commented Jan 11, 2024

Thanks @spehl-max! This looks good. I'll merge in the next day or two.

@drazvan drazvan self-assigned this Jan 11, 2024
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drazvan drazvan merged commit b478e43 into NVIDIA:develop Jan 12, 2024
@drazvan drazvan added this to the v0.7.0 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants